Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a styling issue in the NavigationSideBar component by adding a conditional border on the right side when using the white theme. This brings the sidebar's styling in line with the main NavigationBar component, which already has this border implemented.
Changes:
- Added conditional
borderRightstyling to NavigationSideBar for white theme consistency - Imported
neutralcolor palette to support the border styling - Updated package version to 1.23.8 with corresponding release notes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/NavigationBar/NavigationSideBar.tsx | Added neutral import and conditional borderRight property to match NavPanel styling when using white theme |
| src/stories/ReleaseNotes.stories.tsx | Added release note entry for version 1.23.8 documenting the NavigationSideBar border fix |
| package.json | Bumped version from 1.23.7 to 1.23.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(NavigationSideBar): fix border right